Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.0 release #20

Merged
merged 75 commits into from
Nov 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
e7cb9d3
Add CHANGELOG.md
ShreckYe Oct 20, 2024
0bca06b
Update CHANGELOG.md
ShreckYe Oct 20, 2024
7f60a99
Create kotlin-jvm-ci.yml with our workflow template
ShreckYe Nov 4, 2024
16aa231
Configure the Dokka Gradle plugin, its tasks, and the GitHub Actions …
ShreckYe Nov 6, 2024
dd5fa21
Merge pull request #11 from huanshankeji/dokka-github-pages-deployment
ShreckYe Nov 6, 2024
45a98bf
Update README.md about the API documentation
ShreckYe Nov 6, 2024
9a6fb12
Use the new `com.huanshankeji.team.dokka.github-dokka-convention` plugin
ShreckYe Nov 7, 2024
d9eb743
Create CODE_OF_CONDUCT.md
ShreckYe Nov 7, 2024
3ac08d8
Create CONTRIBUTING.md
ShreckYe Nov 7, 2024
c3f1c89
Apply the binary compatibility validator Gradle plugin
ShreckYe Nov 8, 2024
ed81cd8
Run `apiDump`
ShreckYe Nov 8, 2024
33f0abd
Run Code Cleanup with IntelliJ IDEA and revert some erroneous or unne…
ShreckYe Nov 14, 2024
de09f99
Review the actual arguments of the type parameter `T` in `UpdateBuild…
ShreckYe Nov 14, 2024
c03ede0
Adapt to the new SELECT DSL
ShreckYe Nov 14, 2024
dc741e6
Merge branch 'main' into dev-dependent-on-snapshots
ShreckYe Nov 14, 2024
f631294
Run `apiDump` and review the changes
ShreckYe Nov 14, 2024
31629f3
Remove an obsolete TODO that should've been removed in commit c03ede0…
ShreckYe Nov 14, 2024
a105a4d
Rename the SQL DSL functions taking mapper parameters, adding "withMa…
ShreckYe Nov 14, 2024
6b1a872
Run `apiDump`
ShreckYe Nov 14, 2024
db34477
Use `TableAwareWithSqlExpressionBuilderBuildWhere`, and run `apiDump`…
ShreckYe Nov 14, 2024
eef978f
Add some `@see` references in the KDocs for batch execution
ShreckYe Nov 14, 2024
c534750
Create modules/subprojects to split code into, and move the example a…
ShreckYe Nov 15, 2024
58f65e3
Run `apiDump` and remove the old dumped "exposed-vertx-sql-client-pos…
ShreckYe Nov 15, 2024
e101fc8
Add an additional dependency on the "core" module for the benchmark c…
ShreckYe Nov 15, 2024
7b0fc9f
Generalize the functions in "DatabaseClient.kt" using `PgPool` and `P…
ShreckYe Nov 15, 2024
e959812
Get rid of usages of `PgPool` which was deprecated in 4.5
ShreckYe Nov 15, 2024
dfd0d3b
Initially overhaul and reorganize the APIs
ShreckYe Nov 16, 2024
6b1547e
Move "VertxSqlClients.kt"
ShreckYe Nov 17, 2024
21d34c5
Move code related only to PostgreSQL into the `postgresql` subpackage
ShreckYe Nov 17, 2024
603dbb7
Remove a TODO which was already achieved in commit dfd0d3b5762b044c37…
ShreckYe Nov 17, 2024
fdc2023
Completely overhaul the client creation APIs
ShreckYe Nov 19, 2024
198ebf2
Update README.md
ShreckYe Nov 19, 2024
d4773cd
Remove the factory interfaces which are not needed any more with the …
ShreckYe Nov 19, 2024
496c354
Remove default arguments in the `createGeneric...` functions because …
ShreckYe Nov 19, 2024
82b23fa
Extract a `withCoConnectHandle` extension function
ShreckYe Nov 19, 2024
cecd5be
Move a TODO
ShreckYe Nov 19, 2024
d0e1f3e
Add a "sql-dsl" module
ShreckYe Nov 19, 2024
ef6d3d1
Move some code to https://github.com/huanshankeji/kotlin-common
ShreckYe Nov 19, 2024
daf69d7
Resolve a build issue in the `benchmarks` source set of the "integrat…
ShreckYe Nov 19, 2024
2d7b2a5
Move all the code in the package `postgresql` into the "postgresql" m…
ShreckYe Nov 19, 2024
59a26a6
Move the code that belongs to the modules "sql-dsl" and "sql-dsl-with…
ShreckYe Nov 19, 2024
6eb83a7
Run `apiDump` and ensure that `check` is successful
ShreckYe Nov 19, 2024
263cc5c
Print the number of processors and add a comment in `multiThreadMulti…
ShreckYe Nov 19, 2024
210529d
Add `multiThreadConcurrent10KTransactionsWithThreadLocalDatabases` an…
ShreckYe Nov 19, 2024
3715550
Fix a bug that `awaitAny` is used
ShreckYe Nov 19, 2024
920627f
Make `CoroutineScope` the receiver in `awaitAsync10KTransactions` and…
ShreckYe Nov 19, 2024
9a93c0e
Merge branch 'improve-benchmark' into split-modules-and-decouple
ShreckYe Nov 19, 2024
90dc927
Update README.md corresponding to the split modules
ShreckYe Nov 20, 2024
84ae817
Merge pull request #16 from huanshankeji/split-modules-and-decouple
ShreckYe Nov 20, 2024
6508468
Remove an unnecessary line break
ShreckYe Nov 20, 2024
d373943
Bump Exposed to 0.56.0
ShreckYe Nov 24, 2024
5cf8b81
Move a TODO and the "exposed-jdbc" dependency to the "postgresql" module
ShreckYe Nov 24, 2024
853c0ef
Deprecate `ConnectionType`
ShreckYe Nov 24, 2024
62a09a3
Undo the previous commit and add `LocalConnectionConfig.getConnection…
ShreckYe Nov 24, 2024
b835816
Move the module-wide to `conventions.gradle.kts`
ShreckYe Nov 25, 2024
4d0075d
Make `DatabaseClient` implement `CoroutineAutoCloseable`
ShreckYe Nov 25, 2024
4a47053
Run `apiDump` and review the changes
ShreckYe Nov 25, 2024
47d4006
Add a version of `selectWithMapper` without `buildQuery`
ShreckYe Nov 25, 2024
44ef514
Run `apiDump`
ShreckYe Nov 25, 2024
74dca80
Bump "exposed-adt-mapping" to v0.3.0-SNAPSHOT which depends on Expose…
ShreckYe Nov 26, 2024
4c64c62
Give up (maybe temporarily) calling `PgPoolOptions.setUpConventionall…
ShreckYe Nov 26, 2024
f2b15f5
Add a some new benchmarks to benchmark awaiting dummy `async`s in `ru…
ShreckYe Nov 26, 2024
1bdd2cb
Run the benchmarks of awaiting dummy `async`s on both a Mac with M1 a…
ShreckYe Nov 26, 2024
8f16886
Move the coroutine benchmark code to another package of its own
ShreckYe Nov 26, 2024
24befd4
Update a TODO
ShreckYe Nov 27, 2024
9de472c
Check the instructions on sharing/reusing an Exposed `Database`, and …
ShreckYe Nov 27, 2024
0ef8aa2
Benchmark `Dispatchers.Unconfined` in the benchmarks
ShreckYe Nov 27, 2024
c1ab4a8
Benchmark awaiting heavier computations in the benchmarks
ShreckYe Nov 27, 2024
0c5fe28
Comment out a dependency that's no longer needed
ShreckYe Nov 27, 2024
e0e7265
Make wrapping executing blocking Exposed statements in `Dispatchers.I…
ShreckYe Nov 27, 2024
0ccb6f5
Remove a redundant pair of parentheses
ShreckYe Nov 28, 2024
8e7196f
Add part of the change log for v0.5.0
ShreckYe Nov 29, 2024
a6ead33
Bump the snapshot dependencies to the stable versions
ShreckYe Nov 29, 2024
2707fa1
Merge pull request #14 from huanshankeji/dev-dependent-on-snapshots
ShreckYe Nov 29, 2024
4616634
Complete the change log for v0.5.0, and review and update the example…
ShreckYe Nov 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions .github/workflows/dokka-gh-pages.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
name: Deploy the API documentation to GitHub Pages with Dokka

on:
push:
branches: [ "plugins-release" ]
pull_request:
branches: [ "plugins-release" ]

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:

# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
permissions:
contents: read
pages: write
id-token: write

# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
concurrency:
group: "pages"
cancel-in-progress: false

jobs:
# Build job
build:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup Pages
uses: actions/configure-pages@v5

- name: Set up JDK 8
uses: actions/setup-java@v4
with:
java-version: "8"
distribution: "temurin"

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4

- name: Build the distribution with Gradle Wrapper
run: ./gradlew :dokkaGeneratePublicationHtml

- name: Upload artifact
uses: actions/upload-pages-artifact@v3
with:
path: build/dokka/html/

# Deployment job
deploy:
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
runs-on: ubuntu-latest
needs: build
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
45 changes: 45 additions & 0 deletions .github/workflows/kotlin-jvm-ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: CI

on:
push:
branches: [ "*" ]
# pull_request:
# branches: [ "*" ]

jobs:
check:

runs-on: ubuntu-latest
permissions:
contents: read

steps:
- uses: actions/checkout@v4
- name: Set up JDK 8
uses: actions/setup-java@v4
with:
java-version: '8'
distribution: 'temurin'

- name: Setup Gradle
uses: gradle/actions/setup-gradle@v4

- name: Check with Gradle Wrapper
run: ./gradlew check

dependency-submission:

runs-on: ubuntu-latest
permissions:
contents: write

steps:
- uses: actions/checkout@v4
- name: Set up JDK 8
uses: actions/setup-java@v4
with:
java-version: '8'
distribution: 'temurin'

- name: Generate and submit dependency graph
uses: gradle/actions/dependency-submission@v4
47 changes: 47 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Change log

## v0.5.0 / 2024-11-29

Because of [the Exposed SELECT DSL design changes](https://github.com/JetBrains/Exposed/pull/1916), and also because the old `DatabaseClient` creation APIs were poorly designed and too cumbersome, causing additional cognitive burdens on the users, this release has been completely overhauled. Some old APIs are removed directly because deprecating and delegating them to new ones fills the code base with unused code. Therefore, this release is **not source-compatible or binary-compatible** with v0.4.0. Please do not update unless you have time to adapt to the refactored changes. We are sorry for the inconvenience. From this version on, we will try to maintain source and binary compatibility, deprecating APIs instead of removing them in the foreseeable future.

Please check out the [updated README](README.md) to upgrade to v0.5.0.

Functional changes:

* adapt to [the Exposed SELECT DSL design changes](https://github.com/JetBrains/Exposed/pull/1916) (resolve #8)
* rename the SQL DSL functions taking mapper parameters, adding "withMapper" prefixes (resolve #6)
* split the library into multiple modules including "core", "postgresql", "sql-dsl", and "sql-dsl-with-mapper"
* generalize the functions with the types `PgPool` and `PgConnection` to work with different RDBMSs, replacing them with `Pool` and `SqlConnection`
* get rid of all usages of `PgPool` which was deprecated in Vert.x 4.5
* extract some new APIs and move some existing APIs into finer-grained subpackages, including `jdbc`, `exposed`, `vertx.sqlclient`, and `local` in the "core" module, and `postgresql` in the "postgresql" module
* overhaul the APIs related to the creation of Exposed `Database`s, Vert.x SQL clients, and `DatabaseClient`s

* remove the `create...andSetRole` functions to create Vert.x SQL Clients, with their functionalities merged into the `create...` functions to create Vert.x SQL Clients

* refactor the Exposed `Database` and Vert.x `SqlClient` creation APIs to be more configurable and straightforward

* remove the extra shortcut `DatabaseClient` creation APIs such as `createPgPoolDatabaseClient` as they were poorly designed and too cumbersome, causing additional cognitive burdens on the users

There are too many different combinations with different RDMBSs such as PostgreSQL and MySQL, and different Vert.x SQL Clients such as `SqlClient`, `Pool`, and `SqlConnection`. Therefore we don't provide such shortcut APIs anymore as they are just too cumbersome and cause additional cognitive burdens on the users, and we encourage the library users to create their own (see the updated guide in README.md for instructions). In this way, the Exposed `Databse`s and Vert.x SQL Clients are also more configurable.

* adopt `EvscConfig` as the single-source-of-truth database client config and no longer prefer local connections

`LocalConnectionConfig` should be converted to `EvscConfig` or `ConnectionConfig` to be used.

* mark some APIs as experimental as they are subject to change
* make `DatabaseClient` implement our new `CoroutineAutoCloseable` interface
* add a version of `selectWithMapper` without `buildQuery`
* point out in the usage guide that you are encouraged to share/reuse an Exposed `Database` which generates SQLs among multiple `DatabaseClient`s in multiple verticles, which improves performance as shown in our benchmark results

Miscellaneous changes:

* add API documentation generated by Dokka hosted at <https://huanshankeji.github.io/exposed-vertx-sql-client/>
* add CODE_OF_CONDUCT.md and CONTRIBUTING.md
* use the Kotlin binary compatibility validator
* bump Exposed to v0.56.0

## v0.4.0 / 2024-10-19

* bump Exposed to 0.53.0
* fix a bug that an Exposed transaction is required if a query `FieldSet` contains custom functions depending on dialects and no such a transaction is provided
* Add a basic usage guide
128 changes: 128 additions & 0 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,128 @@
# Contributor Covenant Code of Conduct

## Our Pledge

We as members, contributors, and leaders pledge to make participation in our
community a harassment-free experience for everyone, regardless of age, body
size, visible or invisible disability, ethnicity, sex characteristics, gender
identity and expression, level of experience, education, socio-economic status,
nationality, personal appearance, race, religion, or sexual identity
and orientation.

We pledge to act and interact in ways that contribute to an open, welcoming,
diverse, inclusive, and healthy community.

## Our Standards

Examples of behavior that contributes to a positive environment for our
community include:

* Demonstrating empathy and kindness toward other people
* Being respectful of differing opinions, viewpoints, and experiences
* Giving and gracefully accepting constructive feedback
* Accepting responsibility and apologizing to those affected by our mistakes,
and learning from the experience
* Focusing on what is best not just for us as individuals, but for the
overall community

Examples of unacceptable behavior include:

* The use of sexualized language or imagery, and sexual attention or
advances of any kind
* Trolling, insulting or derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or email
address, without their explicit permission
* Other conduct which could reasonably be considered inappropriate in a
professional setting

## Enforcement Responsibilities

Community leaders are responsible for clarifying and enforcing our standards of
acceptable behavior and will take appropriate and fair corrective action in
response to any behavior that they deem inappropriate, threatening, offensive,
or harmful.

Community leaders have the right and responsibility to remove, edit, or reject
comments, commits, code, wiki edits, issues, and other contributions that are
not aligned to this Code of Conduct, and will communicate reasons for moderation
decisions when appropriate.

## Scope

This Code of Conduct applies within all community spaces, and also applies when
an individual is officially representing the community in public spaces.
Examples of representing our community include using an official e-mail address,
posting via an official social media account, or acting as an appointed
representative at an online or offline event.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported to the community leaders responsible for enforcement at
[email protected].
All complaints will be reviewed and investigated promptly and fairly.

All community leaders are obligated to respect the privacy and security of the
reporter of any incident.

## Enforcement Guidelines

Community leaders will follow these Community Impact Guidelines in determining
the consequences for any action they deem in violation of this Code of Conduct:

### 1. Correction

**Community Impact**: Use of inappropriate language or other behavior deemed
unprofessional or unwelcome in the community.

**Consequence**: A private, written warning from community leaders, providing
clarity around the nature of the violation and an explanation of why the
behavior was inappropriate. A public apology may be requested.

### 2. Warning

**Community Impact**: A violation through a single incident or series
of actions.

**Consequence**: A warning with consequences for continued behavior. No
interaction with the people involved, including unsolicited interaction with
those enforcing the Code of Conduct, for a specified period of time. This
includes avoiding interactions in community spaces as well as external channels
like social media. Violating these terms may lead to a temporary or
permanent ban.

### 3. Temporary Ban

**Community Impact**: A serious violation of community standards, including
sustained inappropriate behavior.

**Consequence**: A temporary ban from any sort of interaction or public
communication with the community for a specified period of time. No public or
private interaction with the people involved, including unsolicited interaction
with those enforcing the Code of Conduct, is allowed during this period.
Violating these terms may lead to a permanent ban.

### 4. Permanent Ban

**Community Impact**: Demonstrating a pattern of violation of community
standards, including sustained inappropriate behavior, harassment of an
individual, or aggression toward or disparagement of classes of individuals.

**Consequence**: A permanent ban from any sort of public interaction within
the community.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage],
version 2.0, available at
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.

Community Impact Guidelines were inspired by [Mozilla's code of conduct
enforcement ladder](https://github.com/mozilla/diversity).

[homepage]: https://www.contributor-covenant.org

For answers to common questions about this code of conduct, see the FAQ at
https://www.contributor-covenant.org/faq. Translations are available at
https://www.contributor-covenant.org/translations.
23 changes: 23 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Contributing guidelines

Hello, thank you for your interest in contributing to our project.

## Issues and Discussions

You are welcome to submit issues on bugs or feature requests. If you have questions, please ask them in GitHub Discussions.

## Pull requests

If you want to contribute to the code of our project, you are welcome to open pull requests. However, it's always a good idea to open a related issue or talk with us in Discussions first.

## Development

Please make sure you have a valid JDK installed. Some projects may require multiple JDKs of different versions. The JDK version we use can be found in the [GitHub Actions workflow files](.github/workflows).

We recommend developing with IntelliJ IDEA. In IntelliJ IDEA, select the correct [Project SDK in Project Structure](https://www.jetbrains.com/help/idea/project-settings-and-structure.html#project-sdk) and it's recommended to set [Gradle JVM](https://www.jetbrains.com/help/idea/gradle-jvm-selection.html#jvm_settings) to "Project SDK".

Run the `publishToMavenLocal` Gradle task to publish the libraries to your machine's Maven Local Repository so your projects can depend on the changes you have made, run `check` to ensure our limited number of tests pass.

## Furthur notice

We are currently a small team with limited effort. While we may not always implement your requested features, merge your pull requests, or do such things in time, you are always welcome to create your own fork and make any changes you like.
Loading
Loading