Depend on snapshots, adapt to the new Exposed DSL, split modules, and completely overhaul the client creation APIs #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve #8 Some functions' signatures are changed so binary compatibility is not maintained. The project version is bumped BTW.
…pper" prefixes Resolve #6 Two "delete" functions were mistakenly added in this file and its `com.huanshankeji.exposedvertxsqlclient.sql.mapping` package, and are now moved out into `com.huanshankeji.exposedvertxsqlclient.sql`. A TODO is removed with its content moved into README.md.
… which doesn't make any difference
…nd benchmark code into the module "integrated" IntelliJ IDEA Code Analysis shows there are 5 errors.
…tgresql.api" file
…gConnection` for different DBs, replacing them with `Pool` and `Connection` A new `withTypedTransaction` function is added and `withPgTransaction` is moved into the `postgresql` package.
Major changes: 1. move some code to finer-grained subpackages 1. initially overhaul the APIs related to the creation of Vert.x SQL clients and `DatabaseClient`s The `create...andSetRole` functions are removed, and their functionalities are merged into the `create...` functions. 1. add TODOs as guidance for the remaining work
1. move code related to `PostgreSQL` into the `postgreql` package 1. refactor the Vert.x `SqlClient` and Exposed `Database` creation APIs to be more configurable and straightforward 1. extract some common functions for JDBC, Exposed, and Vert.x 1. move the example code into the `main` source set 1. remove the extra `DatabaseClient` creation APIs `create*DatabaseClient` 1. adopt `EvscConfig` as the single-source-of-truth client config 1. add some more TODOs 1. update the example code README.md correspondingly
ShreckYe
changed the title
…current API design
…users usually don't call them directly and by doing this we don't forget to pass arguments in a caller
The corresponding commit: huanshankeji/kotlin-common@1b93c18
…ed" module
```text
Execution failed for task ':exposed-vertx-sql-client-integrated:compileBenchmarksKotlin'.
> Could not resolve all files for configuration ':exposed-vertx-sql-client-integrated:benchmarksCompileClasspath'.
> Could not resolve all dependencies for configuration ':exposed-vertx-sql-client-integrated:benchmarksCompileClasspath'.
> Could not find io.vertx:vertx-sql-client:.
Required by:
project :exposed-vertx-sql-client-integrated > project :exposed-vertx-sql-client-core
```
Split modules, completely overhaul the client creation APIs, and decouple PostgreSQL, our SQL DSL APIs, and our mapper SQL DSL APIs
…d v0.56.0 to resolve some binary incompatibilities as found out in internal projects, and update README.md to remind people about the Exposed version
…y` because the following error occurs probably when calling `withTransaction` in an internal project: ``` Cannot acquire a connection on a pipelined pool io.vertx.core.impl.NoStackTraceThrowable: Cannot acquire a connection on a pipelined pool ```
…nBlocking` as a comparison for `TransactionBenchmark`
…nd an Ubuntu PC with AMD Ryzen™ 3900X, add more warmup and measurement iterations because the results are unstable, and rerun The benchmark results of both show that with `runBlocking`: no dispatcher argument > `Dispatchers.Default` > `newSingleThreadContext` > `Dispatchers.IO`. The Mac with a lower Geekbench multi-core score generally outperforms the Ubuntu PC, except for the one with `Dispatchers.IO`, which is interesting.
…update the example code with 3 different kinds of `SqlClient`s
Some conclusions: 1. Calling `runBlocking` without a `CoroutineContext` should be equivalent to calling it with `Dispatchers.Unconfined`, both of which run on the original single thread of the caller. 1. Awaiting empty `async`s is dependent on single-core performance. 1. Both `Dispatchers.Default` and `Dispatchers.IO` utilize all the cores for computation. 1. `await` is much heavier on `Dispatchers.IO`. 1. `await` is lightest when calling `runBlocking` without a `CoroutineContext` or on `Dispatchers.Unconfined`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.