Save the ViewModel states on JS DOM, especially during navigation #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… try adding back some code related to `viewModelStoreOwner`
The added code in the "common" module is temporarily commented out to see whether it's necessary. Under such a condition, an exception is thrown with the message "No ViewModelStoreOwner was provided via LocalViewModelStoreOwner" on JS DOM in an internal app but not in the demo.
…he necessary dependencies, and update the demo `Material3` composable to use a `Material3ViewModel` to demonstrate ViewModels An exception is thrown with the message "ViewModelStore should be set before setGraph call" on JS DOM in an internal app when navigating back.
…nd the issue in commit 0209d15 is resolved
…see whether there is more ViewModel-related code to copy and adapt here, and merge its changes since last time
… also related to animations and transitions, and navigation is manually tested to work without it
This reverts commit ebfa280.
ShreckYe
commented
Jan 8, 2025
navigation/src/jsMain/kotlin/com/huanshankeji/androidx/navigation/compose/NavHost.js.kt
Outdated
Show resolved
Hide resolved
navigation/src/jsMain/kotlin/com/huanshankeji/androidx/navigation/compose/NavHost.js.kt
Outdated
Show resolved
Hide resolved
…le since the "navigation" module depends on the "lifecycle-viewmodel" via api now
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://developer.android.com/develop/ui/compose/state-saving#business-logic.