Move the hierarchy template to common-conventions and move the `com…

…pose.ui` dependency to the common `composeUiMain` source set
huanshankeji · Dec 4, 2024 · 58da79f · 58da79f
1 parent a8705e5
commit 58da79f
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 29 deletions.
diff --git a/buildSrc/src/main/kotlin/common-conventions.gradle.kts b/buildSrc/src/main/kotlin/common-conventions.gradle.kts
@@ -38,7 +38,21 @@ kotlin {
     js()
 
 
+
     @OptIn(ExperimentalKotlinGradlePluginApi::class)
+    applyDefaultHierarchyTemplate {
+        common {
+            group("composeUi") {
+                withJvm()
+                withAndroidTarget()
+                group("ios")
+                withWasmJs()
+            }
+        }
+    }
+
+
+
     compilerOptions {
         freeCompilerArgs.add("-Xexpect-actual-classes")
     }

diff --git a/buildSrc/src/main/kotlin/lib-conventions-without-publishing.gradle.kts b/buildSrc/src/main/kotlin/lib-conventions-without-publishing.gradle.kts
@@ -1,5 +1,3 @@
-import org.jetbrains.kotlin.gradle.ExperimentalKotlinGradlePluginApi
-
 plugins {
     id("common-conventions")
     id("com.huanshankeji.kotlin-multiplatform-conventional-targets")
@@ -11,20 +9,6 @@ kotlin {
         publishLibraryVariants("release", "debug")
     }
 
-    // move to `common-conventions` if necessary
-
-    @OptIn(ExperimentalKotlinGradlePluginApi::class)
-    applyDefaultHierarchyTemplate {
-        common {
-            group("composeUi") {
-                withJvm()
-                withAndroidTarget()
-                group("ios")
-                withWasmJs()
-            }
-        }
-    }
-
     /*
     sourceSets {
         val composeUiMain by creating { dependsOn(commonMain.get()) }

diff --git a/demo/build.gradle.kts b/demo/build.gradle.kts
@@ -57,30 +57,22 @@ kotlin {
                 implementation(commonDependencies.kotlinx.coroutines.core())
             }
         }
+        composeUiMain {
+            dependencies {
+                implementation(compose.ui)
+            }
+        }
         jvmMain {
             dependencies {
                 implementation(compose.desktop.currentOs)
             }
         }
         androidMain {
             dependencies {
-                // TODO consider putting this in `composeUiMain`
-                implementation(compose.ui)
-
                 implementation(commonDependencies.androidx.activity.compose())
                 implementation(commonDependencies.androidx.compose.ui.module("tooling-preview"))
             }
         }
-        iosMain {
-            dependencies {
-                implementation(compose.ui)
-            }
-        }
-        wasmJsMain {
-            dependencies {
-                implementation(compose.ui)
-            }
-        }
         jsMain {
             dependencies {
                 implementation(compose.html.core)