Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ClientTimeoutSuite #5761

Conversation

RafalSumislawski
Copy link
Member

This PR solves the following problems:

  • The use of QueueTestHead with onFinalizeWeak which is by it's nature racy and leads to flaky tests. (this half solves Redesign tests based on QueueTestHead and onFinalizeWeak blaze#703)
  • Incorrect construction of connections, leading to to the IdleTimoutStage not being included in the pipelinie (it used to be added in mkConnection but then removed in MockClientBuilder)
  • All tests of idle-timeout passing despite the issue mentioned above. (This is solved by redefining the "Not timeout on only marginally slow request body" in such a way that it would fail if the IdleTimeoutStage wasn't included in the pipeline)

Additionally it:

  • improves test coverage by dividing "Idle timeout on slow POST body" into two test cases, one of which is currently failing due to a flaw in blaze client implementation (I think Resourcify blaze client #5385 will solve it).
  • reduces amount of code

@RafalSumislawski RafalSumislawski added testing Issues related to tests series/0.22 PRs targeting 0.22.x labels Dec 19, 2021
Copy link
Member

@danicheg danicheg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding comments for those test suites. So much appreciated.

@RafalSumislawski RafalSumislawski merged commit b969a4e into http4s:series/0.22 Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
series/0.22 PRs targeting 0.22.x testing Issues related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants