Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the following problems:
QueueTestHead
withonFinalizeWeak
which is by it's nature racy and leads to flaky tests. (this half solves Redesign tests based onQueueTestHead
andonFinalizeWeak
blaze#703)IdleTimoutStage
not being included in the pipelinie (it used to be added inmkConnection
but then removed inMockClientBuilder
)IdleTimeoutStage
wasn't included in the pipeline)Additionally it: