Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prefix _root_ when referring to scala type #72

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't prefix _root_ when referring to scala type #72

wants to merge 1 commit into from

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge mentioned this pull request Oct 23, 2023
Open
@armanbilge armanbilge marked this pull request as draft January 26, 2024 22:39
@danicheg
Copy link
Member

danicheg commented May 7, 2024

@armanbilge hey! what does stop us from merging this?

@armanbilge
Copy link
Member Author

I wrote some comments in #70 (comment). I think I realized that this fix is broken.

@danicheg
Copy link
Member

danicheg commented May 7, 2024

Ah, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated code is invalid for well-known types
2 participants
@armanbilge @danicheg