-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mismatching of sentence final punctuation #100
Changes from all commits
aa60c0e
701ead2
a9d4c11
1fd0c5d
8d15e8e
dcaaff0
61f4671
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"type": "bilingual", | ||
"description": "Fixes mismatched punctuation at the end of the sentences. Works for latin/cyrillic based languages, WILL BREAK CJK AND ANY LANGUAGE THAT USES NON ENGLISH LIKE SENTENCE ENDING TOKENS.", | ||
"parameters": {}, | ||
"command": "./fix_sent_final_punct.py" | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
#!/usr/bin/env python3 | ||
import sys | ||
|
||
my_punct = {'!', '"', '#', '$', '%', '&', "'", '(', ')', '*', '+', ',', '.', '/', ':', ';', '<', '=', '>', '?', '@', '[', '\\', ']', '^', '_', '`', '{', '|', '}', '~', '»', '«', '“', '”'} | ||
|
||
for line in sys.stdin: | ||
src, trg = line.rstrip("\r\n").split("\t") | ||
if len(src) == 0 or len(trg) == 0: | ||
print(src + '\t' + trg) | ||
continue | ||
|
||
# Sometimes we have a space between the final letter and the punctuation, which is wrong except if using french quotes | ||
if len(src) >= 2 and src[-1] in my_punct and src[-2] == " " and src[-1] != '»' and src[-1] != '«': | ||
src = src[:-2] + src[-1] | ||
if len(trg) >= 2 and trg[-1] in my_punct and trg[-2] == " " and trg[-1] != '»' and trg[-1] != '«': | ||
trg = trg[:-2] + trg[-1] | ||
# Sometimes two punctuation marks are swapped... | ||
if len(src) >=2 and len(trg) >= 2 and src[-2] == trg[-1] and src[-1] == trg[-2]: | ||
trg = trg[:-2] + src[-2] + src[-1] | ||
# Sometimes they are swapped with space around eg SPACE». -> .SPACE» | ||
if len(src) >=3 and src[-1] in my_punct and src[-2] == '»' and src[-3] == ' ': | ||
src = src[:-3] + src[-1] + ' ' + src[-2] | ||
if len(trg) >=3 and trg[-1] in my_punct and trg[-2] == '»' and trg[-3] == ' ': | ||
trg = trg[:-3] + trg[-1] + ' ' + trg[-2] | ||
|
||
|
||
# check for the french quotes special case | ||
if (src[-1] == '»' or src[-1] == '«') and trg[-1] not in my_punct: | ||
trg = trg + '"' | ||
elif (trg[-1] == '»' or trg[-1] == '«') and src[-1] not in my_punct: | ||
src = src + '"' | ||
elif src[-1] in my_punct and trg[-1] not in my_punct: | ||
trg = trg + src[-1] | ||
elif trg[-1] in my_punct and src[-1] not in my_punct: | ||
src = src + trg[-1] | ||
# Final case. Fix mismatched punctuation on the src and trg. EXCEPT in cases like french quotes. And in cases where we have emdash at the front, as it means spech | ||
elif trg[-1] in my_punct and src[-1] in my_punct and src[-1] != trg[-1] and src[-1] != '»' \ | ||
and src[-1] != '«' and trg[-1] != '»' and trg[-1] != '«' and src[0] != '–' and trg[0] != '–' and src[0] != '—' and trg[0] != '—': | ||
Comment on lines
+37
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Putting the special cases like What about the situation when we have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
trg = trg[:-1] + src[-1] | ||
print(src + '\t' + trg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if there are two spaces/end puncts? Such as
weird quote ."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other filters should take care of this (normalising whitespace)
OpusCleaner/opuscleaner/filters/fix_sent_final_punct.py
Line 13 in dcaaff0