-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of traits for coverage testing #572
Draft
LinqLover
wants to merge
12
commits into
hpi-swa:master
Choose a base branch
from
LinqLover:fix-coverage-traits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Sep 29, 2022
-
Fix file paths for coverage reports
Implement and test proper handling of class-side methods, extension methods, trait methods, and special message selectors.
Configuration menu - View commit details
-
Copy full SHA for b3a3bb8 - Browse repository at this point
Copy the full SHA b3a3bb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c9ddb6 - Browse repository at this point
Copy the full SHA 4c9ddb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d899dd - Browse repository at this point
Copy the full SHA 9d899ddView commit details -
Fix handling of trait methods for coverage testing
Depends on Traits-eventualUsers.3.cs and complements SUnit coverage for traits.2.cs. [1] The implementation mostly follows the design of SUnit coverage for traits.2.cs [1], this implementation for smalltalkCI also makes the following changes: * Moves exclusion of methods derived from traits up from Pharo's overrides of #allClassesToCover to new SCICodeCoverage class>>#cannotBeCovered: * Moves check for abstract methods from SCICodeCoverage class>>#isExcluded: to SCICodeCoverage class>>#cannotBeCovered:. Consequently, abstract methods will no longer will be displayed as "ignored" but hidden at all from the coverage report. [1] https://lists.squeakfoundation.org/pipermail/squeak-dev/2022-September/222291.html
Configuration menu - View commit details
-
Copy full SHA for cd6d13e - Browse repository at this point
Copy the full SHA cd6d13eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a069a7 - Browse repository at this point
Copy the full SHA 5a069a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 750908b - Browse repository at this point
Copy the full SHA 750908bView commit details
Commits on Sep 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 10b952b - Browse repository at this point
Copy the full SHA 10b952bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a197651 - Browse repository at this point
Copy the full SHA a197651View commit details
Commits on Oct 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3095b6a - Browse repository at this point
Copy the full SHA 3095b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34aeff6 - Browse repository at this point
Copy the full SHA 34aeff6View commit details -
Lol, I had installed an extension that would automatically try to regenerate the TOC upon every save (markdown.extension.toc.updateOnSave) ...
Configuration menu - View commit details
-
Copy full SHA for 6f6c163 - Browse repository at this point
Copy the full SHA 6f6c163View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8250969 - Browse repository at this point
Copy the full SHA 8250969View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.