Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of traits for coverage testing #572

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Commits on Sep 29, 2022

  1. Fix file paths for coverage reports

    Implement and test proper handling of class-side methods, extension methods, trait methods, and special message selectors.
    LinqLover committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    b3a3bb8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c9ddb6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d899dd View commit details
    Browse the repository at this point in the history
  4. Fix handling of trait methods for coverage testing

    Depends on Traits-eventualUsers.3.cs and complements SUnit coverage for traits.2.cs. [1]
    
    The implementation mostly follows the design of SUnit coverage for traits.2.cs [1], this implementation for smalltalkCI also makes the following changes:
    * Moves exclusion of methods derived from traits up from Pharo's overrides of #allClassesToCover to new SCICodeCoverage class>>#cannotBeCovered:
    * Moves check for abstract methods from SCICodeCoverage class>>#isExcluded: to SCICodeCoverage class>>#cannotBeCovered:. Consequently, abstract methods will no longer will be displayed as "ignored" but hidden at all from the coverage report.
    
    [1] https://lists.squeakfoundation.org/pipermail/squeak-dev/2022-September/222291.html
    LinqLover committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    cd6d13e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a069a7 View commit details
    Browse the repository at this point in the history
  6. further robustness fixes

    LinqLover committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    750908b View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Configuration menu
    Copy the full SHA
    10b952b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a197651 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Configuration menu
    Copy the full SHA
    3095b6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34aeff6 View commit details
    Browse the repository at this point in the history
  3. Restore TOC in COVERAGE.md

    Lol, I had installed an extension that would automatically try to regenerate the TOC upon every save (markdown.extension.toc.updateOnSave) ...
    LinqLover committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    6f6c163 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8250969 View commit details
    Browse the repository at this point in the history