HPCC-22879 Add parameters to Dockerfiles #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-pan
reviewed
Sep 24, 2019
README.md
Outdated
| @@ -1,87 +1,55 @@ | |||
| # HPCC Systems Platform Community Version | |||
| platform/ | |||
| - ca/base/<version>/Dockerfile: HPCC Systems Platform Community version prequisites (Ubuntu 18.04) | |||
There was a problem hiding this comment.
the -version- tag ONLY displays in this raw mode, it does not display in rich text display... use < (& l t ; and & g t ; ) and > or perhaps change to version
README.md
Outdated
| Docker Hub: hpccsystems/hpcc-base | ||
| - ce/Dockerfile HPCC Systems Platform Community version Docker build file with version as input argument. | ||
| Docker Hub: hpccsystems/platform | ||
| - ln/base/<version>/Dockerfile: HPCC Systems Platform Internal version prequisites (CentOS 7) |
There was a problem hiding this comment.
see previous comment -version- does not like > < in .md file
|
|
||
| plugins/ | ||
| - ce/Dockerfile: HPCC Systems Plugins Community version Docker build file (based Platform Docker image) with version as input argument |
There was a problem hiding this comment.
change to : (based on Platform Docker image)
| To start Docker in interactive mode and map ECLWatch port 8010 to host 8010: | ||
| ```sh | ||
| sudo docker run -t -i -p 8010:8010 hpccsystems/hpcc /bin/bash | ||
| ## How to buid |
README.md
Outdated
| sudo docker run -d -p 8020:8010 hpccsystems/hpcc | ||
| ``` | ||
| # Development and custom Build | ||
| dev/<version> |
There was a problem hiding this comment.
that is hiding the contents on the viewable page.
README.md
Outdated
| ``` | ||
| # Development and custom Build | ||
| dev/<version> | ||
| <bionic|disco|eoan|el7|gcc7|gcc8|gcc9>/ |
There was a problem hiding this comment.
<bionic is OK, but it might be good to put some space here as < bionic | disco | eoan | etc | etc more readable
| sudo docker run -t -i hpccsystems/platform /bin/bash | ||
| ``` | ||
|
|
||
| # How is this image build |
| sudo docker run -d hpccsystems/clienttools | ||
| ``` | ||
|
|
||
| # How is this image build |
xwang2713
force-pushed
the
Docker-22879-new-layout
branch
2 times, most recently
from
b882dbe to
cc2e2d0
Compare
Add support for two stages Docker image build Add support for HPCC Systems cluster configuration on Kubernetes Add platform/ce/Dockerfile-local
xwang2713
force-pushed
the
Docker-22879-new-layout
branch
2 times, most recently
from
5fbf921 to
b184bdf
Compare
|
Update as mentioned by Greg. |
xwang2713
force-pushed
the
Docker-22879-new-layout
branch
2 times, most recently
from
08df937 to
19c2c50
Compare
Add support for two stages Docker image build Add support for HPCC Systems cluster configuration on Kubernetes Add platform/ce/Dockerfile-local Add PUSH.md
xwang2713
force-pushed
the
Docker-22879-new-layout
branch
from
19c2c50 to
90bc161
Compare
|
@richardkchapman this is ready to merge |
This was referenced Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for two stages Docker image build
Add support for HPCC Systems cluster configuration on Kubernetes
To build HPCC Systems Docker images with a new version using "--build-arg version="
@gfortil please review the code
@g-pan please help review the README.md:
top level README.md
clienttools/ce/README.md
dev/README.md
platform/ce/README.md