-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-33181 Add ZAP information for container deployments to docs #19391
base: candidate-9.8.x
Are you sure you want to change the base?
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33181 Jirabot Action Result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments inline.
Perhaps you should also mention the LDAP setting in https://hpccsystems.atlassian.net/browse/HPCC-33177
<sect3 id="CNT_ESPandECLWatch"> | ||
<title>ESP and ECLWatch </title> | ||
|
||
<para>ECL Watch works much the same way deployed via bare metal or a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence should be removed or reworded.
<para>ECL Watch works much the same way deployed via bare metal or a | ||
container. There are a few exceptions. </para> | ||
|
||
<sect4 id="CNTR_ZAP"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content is good but it feels out of place in the context of the chapter since it doesn't cover configuration settings. . Perhaps it should go in the Logging chapter.
Signed-off-by: Panagiotatos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Containerized HPCC doc Pg. 56
Type of change:
Checklist:
Smoketest:
Testing:
Successfully built all tests passed: https://github.com/g-pan/github-action-dev-build/actions/runs/12680538907