Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33015 Improve system resilience when thor crashes #19309

Merged
merged 1 commit into from
Nov 22, 2024
Merged

HPCC-33015 Improve system resilience when thor crashes #19309

merged 1 commit into from
Nov 22, 2024

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Nov 21, 2024 •
edited
Loading

  • Ensure that a thor engine that has crashed is no longer associated with a workunit
  • Ensure that a thor instance that never processes a workunit terminates cleanly

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33015

Jirabot Action Result:
Assigning user: [email protected]
Workflow Transition To: Merge Pending
Updated PR

ghalliday
ghalliday commented Nov 21, 2024
View reviewed changes
thorlcr/master/thgraphmanager.cpp
if (0 == currentGraphName.length()) // only ever true if !multiJobLinger

// The following is true if no workunit/graph have been received
// MORE: I think it should also be executed if lingerPeriod is 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a separate jira to fix this (when Jake gets back)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghalliday - lingerPeriod cannot be 1 (as defined by the values schema)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.. agree, lingerPeriod is optional (min 1 if set), if it is not set (0).. it does look like it is not exiting correctly, checking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, lingerPeriod cannot be 0. It defaults to 60 seconds, and the schema will not allow it to be set 0.
So the if (lingerPeriod) condition is misleading, it will always enter this block of code in practice.

@ghalliday ghalliday requested a review from mckellyln November 21, 2024 12:17
@ghalliday
Copy link
Member Author

note: This has not been tested.

mckellyln
mckellyln approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mckellyln mckellyln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@ghalliday
HPCC-33015 Improve system resilience when thor crashes
59aeb2b 
* Ensure that a thor engine that has crashed is no longer associated with a workunit
* Ensure that a thor instance that never processes a workunit terminates cleanly

Signed-off-by: Gavin Halliday <[email protected]>
@ghalliday ghalliday merged commit c1ca74e into hpcc-systems:candidate-9.6.x Nov 22, 2024
27 checks passed
@github-actions GitHub Actions
Copy link

Jirabot Action Result:
Added fix version: 9.6.68
Added fix version: 9.8.42
Workflow Transition: 'Resolve issue'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesmith jakesmith jakesmith left review comments

@mckellyln mckellyln mckellyln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghalliday @jakesmith @mckellyln