HPCC-32711 Define LDAP security manager abstraction

[timothyklemm]

Replace platform references to CLdapSecManager with references to the ILdapSecManager abstraction.

Type of change:

• This change is a bug fix (non-breaking change which fixes an issue).
• This change is a new feature (non-breaking change which adds functionality).
• This change improves the code (refactor or other change that does not change the functionality)
• This change fixes warnings (the fix does not alter the functionality or the generated code)
• This change is a breaking change (fix or feature that will cause existing behavior to change).
• This change alters the query API (existing queries will have to be recompiled)

Checklist:

• My code follows the code style of this project.
  • My code does not create any new warnings from compiler, build system, or lint.
• The commit message is properly formatted and free of typos.
  • The commit message title makes sense in a changelog, by itself.
  • The commit is signed.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly, or...
  • I have created a JIRA ticket to update the documentation.
  • Any new interfaces or exported functions are appropriately commented.
• I have read the CONTRIBUTORS document.
• The change has been fully tested:
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have checked that this change does not introduce memory leaks.
  • I have used Valgrind or similar tools to check for potential issues.
• I have given due consideration to all of the following potential concerns:
  • Scalability
  • Performance
  • Security
  • Thread-safety
  • Cloud-compatibility
  • Premature optimization
  • Existing deployed queries will not be broken
  • This change fixes the problem, not just the symptom
  • The target branch of this pull request is appropriate for such a change.
• There are no similar instances of the same problem that should be addressed
  • I have addressed them here
  • I have raised JIRA issues to address them separately
• This is a user interface / front-end modification
  • I have tested my changes in multiple modern browsers
  • The component(s) render as expected

Smoketest:

• Send notifications about my Pull Request position in Smoketest queue.
• Test my draft Pull Request.

Testing:

[github-actions]

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32711

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

[kenrowland]

Unfortunate that it has to be done this way. But looks reasonable to convert to an interface.

[timothyklemm]

@ghalliday please merge.

[timothyklemm]

@ghalliday per our offline discussion today, this change is not necessary for any forthcoming changes. It may still be viewed as a code improvement that decouples the platform from a specific implementation of LDAP. Any security manager plugin that implements the interface can be used instead.

Or it can just be closed.

[ghalliday]

@timothyklemm do you think it is a worthwhile change to keep - I am happy either way.

It does not seem right that anything outside the ldap implementation knows it is an ldap manager, but I suspect that is a far bigger factoring that is required.

[timothyklemm]

@ghalliday unifying the interfaces is a large undertaking. Russ wanted to do it. Ken and I would both like to see it happen. It's never been a high enough priority.

As long as casting is necessary, I think casting to an interface is preferable to a single implementation. Also, the potential for use of the decorator pattern to control/enforce trace settings remains a possibility. I would keep this change.