Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jormungandr] call kraken to compute fare only when pt_planner=loki #4129

Merged
merged 3 commits into from
Oct 6, 2023
Merged

[jormungandr] call kraken to compute fare only when pt_planner=loki #4129

merged 3 commits into from
Oct 6, 2023

Conversation

pbench
Copy link
Contributor

@pbench pbench commented Oct 5, 2023

  • call kraken to compute fare only when pt_planner=loki
  • by default, activate the call to kraken to compute fare

This should :

@pbench pbench requested review from azime, kadhikari and xlqian October 5, 2023 10:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@pbench pbench merged commit c9a4dc0 into dev Oct 6, 2023
9 checks passed
@pbench pbench deleted the fare_call_only_for_loki branch October 6, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlqian xlqian xlqian approved these changes

@azime azime Awaiting requested review from azime

@kadhikari kadhikari Awaiting requested review from kadhikari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbench @xlqian