Function overloading in macros

[ristomatti]

@houmain Would it be a lot of work to support the same macro with varying amount of parameters? Example:

Hold = $0{150ms}
Hold = $0{mul[150, $1]ms}

The idea came from the fact I've found my macros Tap and Hold great ways to make the config more readable and to allow fine tuning the value for all the mappings in one place. But in a few situations I need the value to be longer, but I couldn't come up with a good name. It then occurred to me that using a multiplier would be a even better to have the value relative to the most often needed one.

Currently I've just used HoldX, but I remember having a similar need on some macros that execute commands earlier on. For instance it would be nice to have this

log = $(echo "$1" >> $LOG_FILE)
log = $(pastel --force-color paint "$1" "$0" >> $LOG_FILE)

...rather than this:

log = $(echo "$1" >> $LOG_FILE)
logColor = $(pastel --force-color paint "$1" "$0" >> $LOG_FILE)

What do you think?

[houmain]

Would it be a lot of work to support the same macro with varying amount of parameters?

Not only that, it would be against the design. It is currently allowed to redefine macros, like:

macro = X
A >> macro
macro = Y
B >> macro

So, it would be hard to distinguish between a redefinition and a definition of an overload.

I am thinking about adding a builtin macro default, which would return the second parameter when the first is empty. So this would work:

Hold = $0{mul[150, default[$1, 1]]ms}

I am still thinking about a nice solution for your second sample.

[ristomatti]

And also a $#, which is replaced with the argument count.

Hmm. Could you reconsider using some other character than#? It makes sense given the meaning, but it will mess up the syntax highlighting with the only languages I've got decent results. This is with Starlark, the most keymapper.conf "compatible" one I've come across:

[ristomatti]

Before I discovered Starlark worked so well for this purpose, I went through using Bash, INI and Perl but all of them started falling apart with some of Keymapper's config syntax.

I have even contemplated on trying to write Tree-sitter highlighting queries for Keymapper but the task has so far felt too daunting. I don't even know if it'd be doable without writing a parser, but the highlighting query syntax is already difficult for me to wrap my head around. I might be able to write a TextMate higlighter but unfortunately Helix doesn't support it...

It doesn't help at all Tree-sitter grammars are written in Scheme and I've only worked with languages in the C-family.

[ristomatti]

Perhaps %?

[ristomatti]

Related: https://www.quora.com/Is-the-number-sign-internationally-recognized-to-mean-number

[houmain]

I noticed some commits pushed, do you want me to give it a try it before a release?

Early feedback is always very welcome!

Could you reconsider using some other character than #?

I did not think about that. I just copied the syntax from shell scripts. But since # has indeed been problematic I changed it to $$ now.