Only Show Distinct Artifact Log Ids on Search Results Page #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
requested changes
Jan 9, 2025
| @@ -20,7 +20,7 @@ along with this software (see the LICENSE.md file). If not, see | |||
| </transition> | |||
| <actions> | |||
| <set field="queryString" from="anyField ?: '*' "/> | |||
| <service-call name="co.hotwax.alc.SearchServices.search#ArtifactLogIndexes" in-map="[queryString:queryString, additionalQueryMap:[artifactLogTypeId: artifactLogTypeId], pageIndex:pageIndex, pageSize:pageSize, pageNoLimit:pageNoLimit]" out-map="context"/> | |||
| <service-call name="co.hotwax.alc.SearchServices.search#DistantArtifactLogs" in-map="[queryString:queryString, additionalQueryMap:[artifactLogTypeId: artifactLogTypeId], pageNoLimit:!anyField]" out-map="context"/> | |||
There was a problem hiding this comment.
Spelling
Updated to RecentArtifactLogs
| <set field="queryString" from="queryString ? elasticQueryAutoWildcard(queryString, true) : '*'"/> | ||
| <if condition="queryString"><set field="queryString" from="'(' + queryString + ')'"/></if> | ||
|
|
||
| <script><
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27
This PR addresses the issue of multiple entries for the same Artifact log ID displayed in the search results due to various Artifact events for a particular Artifact Log ID.
Changes Made
Note
Removal of Pagination: Due to limitations with OpenSearch’s support for aggregation with pagination, pagination has been removed from the Find page. This change was necessary to ensure we could retrieve the most recent events for Artifact log IDs by applying aggregations.
From now on, the find page only shows 20 Results by default, and if the user searches on the find page then it shows all the records without any pagination.