Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Add .tools-version file #188

Closed
wants to merge 1 commit into from
Closed

maint: Add .tools-version file #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
golang 1.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, I think this will result in Go 1.18.0, not "the latest 1.18.x".

Copy link
Contributor Author

@MikeGoldsmith MikeGoldsmith Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're correct - it only enforces the major.minor and doesn't care about the patch. However, this is a good step forward to where we didn't enforce any version.

There's an open PR in asdf to try to tackle it but there's mixed opinion on whether it should be part of the core tool or the plugins.

Are you okay with this to start with, then if the asdf supports 'latest' patches we move to that?