[FR] Expand timer naming words #2515
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
@bors-ltd Is the PR ready for review? |
|
Sorry, I was so excited when I found out Home Assistant had voice commands, I got carried away. It reminded me of Snips, glad I kept the devkit. Only later I noticed the test suite, and realised my changes were not covered. But I got busy today and couldn't come back to it. I'll ping you when it's thoroughly tested, and hopefully on real hardware when my ESP32 is delivered. |
bors-ltd
force-pushed
the
patch-1
branch
4 times, most recently
from
d34a7e9
to
b8ab1db
Compare
I find it more natural to say "start a 5 minutes timer for the pizza", or "how much left for the pizza". Also fixed a few typos.
|
Now I feel like pretty happy with the state of that PR, and confident to ask for a review. Please note I'm new to HA, so it may likely not meet your quality standards, and I can accept criticism, even nitpicking. Hopefully I didn't reach any hard limit with Whisper's current capabilities. |
| expansion_rules: | ||
| appele: "(appelé|nommé|surnomé)" | ||
| appele: "(appelé|nommé|surnommé|pour)" |
There was a problem hiding this comment.
| appele: "(appelé|nommé|surnommé|pour)" | |
| appele: "(appelé|nommé|surnommé|pour [<le>])" |
I wonder if we should just use this expansion rule as "Met un minuteur appelé la pizza" doesn't make sense.
WDYT @jlpouffier ?
There was a problem hiding this comment.
I like the idea of limiting the risk of regression for my own use case. I'll try and test on my side.
I find it more natural to say "start a 5 minutes timer for the pizza".
The "surnommé" typo isn't strictly necessary, but it was bothering me.