Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defunct CoinMarketCap integration #46615

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Remove defunct CoinMarketCap integration #46615

merged 1 commit into from
Feb 16, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 16, 2021

Breaking change

The CoinMarketCap integration has been removed. The API used by this integration has been out of service for a while not, breaking this integration.

Proposed change

This PR removes the CoinMarketCap integration. The API used by this integration was officially superseded by the new CoinMarketCap Professional API on December 4, 2018 and had been in a limited state to allow users to migrate before it was fully shut down on March 5, 2020.

References:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been removed.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck marked this pull request as ready for review February 16, 2021 06:18
@yuvalabou yuvalabou mentioned this pull request Feb 16, 2021
21 tasks
@ludeeus ludeeus merged commit a691227 into dev Feb 16, 2021
@ludeeus ludeeus deleted the frenck-2021-0626 branch February 16, 2021 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please remove coinmarketcap integration Coinmarketcap integration broken/outdated. It uses new API now.
4 participants