Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify additional markers for wheel build requirements #129949

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Nov 6, 2024

Proposed change

Required for #129442

Allow adding additional environment markers to requirements override. Will be necessary for pandas with Python 3.13. E.g.

EXTRA_MARKERS_PANDAS_313 = {
     "env-canada": "python_version<'3.13'",
     "noaa-coops": "python_version<'3.13'",
     "pyezviz": "python_version<'3.13'",
     "pykrakenapi": "python_version<'3.13'",
 }

OVERRIDDEN_REQUIREMENTS_ACTIONS = {
    ...
    "wheels_armv7": {
         "exclude": set(),
         "include": INCLUDED_REQUIREMENTS_WHEELS,
         "markers": EXTRA_MARKERS_PANDAS_313,
     },

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner November 6, 2024 12:40
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Nov 6, 2024
@cdce8p cdce8p requested a review from joostlek November 6, 2024 12:51
@cdce8p cdce8p removed the request for review from joostlek November 7, 2024 08:34
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

../Frenck

@frenck frenck merged commit 0a4c0fe into home-assistant:dev Nov 8, 2024
46 checks passed
@cdce8p cdce8p deleted the wheel-markers branch November 8, 2024 20:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants