Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freebox_home icons #6363

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

XAV59213
Copy link

Proposed change
Add icons for https://github.com/gvigroux/freebox_home existing custom integration.

Type of change

Add a new logo or icon for a custom integration (custom component)

create an icon or logo
Additional information
This PR fixes or closes issue: fixes gvigroux/freebox_home#23
Link to custom integration repository: https://github.com/gvigroux/freebox_home
Checklist
The added/replaced image(s) are PNG
Icon image size is 256x256px (icon.png)

Logo image size has min 128px, but max 256px, on the shortest side (logo.png)

@XAV59213 XAV59213 changed the title Create icon.png Add freebox_home icons Jan 14, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @XAV59213 👋

The added image assets don't seem to be valid images. See also:

CleanShot 2025-01-14 at 11 33 11

CleanShot 2025-01-14 at 11 32 56

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 14, 2025 10:33
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Author

@XAV59213 XAV59213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon

@XAV59213 XAV59213 marked this pull request as ready for review January 14, 2025 11:30
@home-assistant home-assistant bot requested a review from frenck January 14, 2025 11:30
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branding is modified from upstream:

CleanShot 2025-01-14 at 14 24 32

We cannot accept such modification, as they are often in violations of upstream branding guidelines.

Please use unmodified versions instead.

Thanks 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 14, 2025 13:25
Copy link
Author

@XAV59213 XAV59213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo

@XAV59213 XAV59213 marked this pull request as ready for review January 14, 2025 13:44
@home-assistant home-assistant bot requested a review from frenck January 14, 2025 13:44
Copy link
Author

@XAV59213 XAV59213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo

Copy link
Author

@XAV59213 XAV59213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo

Copy link
Author

@XAV59213 XAV59213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading logo.png…

Copy link
Author

@XAV59213 XAV59213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intégration logo
2 participants