Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iometer brand #6348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MaestroOnICe
Copy link

@MaestroOnICe MaestroOnICe commented Jan 10, 2025

Proposed change

Add logos and icons for iometer integration

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jan 13, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @MaestroOnICe 👋

I could not find the pull request in the core repository that adds this new integration. Could you point me to it?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 13, 2025 11:27
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MaestroOnICe
Copy link
Author

Hi there @MaestroOnICe 👋

I could not find the pull request in the core repository that adds this new integration. Could you point me to it?

../Frenck

Hi Frenck,

I opened the PR on the core repository a couple of minutes ago and updated this PR with the link to it.

Regards

@MaestroOnICe MaestroOnICe marked this pull request as ready for review January 13, 2025 13:06
@home-assistant home-assistant bot requested a review from frenck January 13, 2025 13:06
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants