Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smartbox custom_integration #6347

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Delmael
Copy link

@Delmael Delmael commented Jan 9, 2025

Proposed change

Adding the custom integration to smartbox (HJM and Haverland).

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/ajtudela/hass-smartbox

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @Delmael 👋

Thanks for the PR, however, this PR contains a product image. We don't collect product images in this repository, but manufacturer branding. In this case I would have expected the branding of Haverland to be in the pull request.

Could you take a look?

Thanks! 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 13, 2025 12:18
@Delmael
Copy link
Author

Delmael commented Jan 13, 2025

Hi there @Delmael 👋

Thanks for the PR, however, this PR contains a product image. We don't collect product images in this repository, but manufacturer branding. In this case I would have expected the branding of Haverland to be in the pull request.

Could you take a look?

Thanks! 👍

../Frenck

Hi @frenck
I clearly understand.
But the smartbox component is used by many brand (HJM, Haverland, Elnur, Helki, etc). These brands use the smartbox and the associated platform as a white brand. They do not have there own plateform.
That's why I've added this icon
Thanks :)
Edouard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants