-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dreo integration brand #6345
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @w-xtao 👋
To ensure the logo looks good in Home Assistant, can we remove some of the white/empty space on the top/bottom of the logo versions?
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The images added now seem to be app icons, and not branding Dreo is using as their brand identity. Please use the original Dreo branding instead.
I'm not sure why you ended up completely replacing all images with something else 🤷
../Frenck
Remove some of white/empty space
Hi @fredck Thank you for your feedback! I have removed the blank space at the top and bottom of the logo and optimized its display. Best regards, |
Remove some of blank/empty space
Remove white/empty blank with logo and replace icon picture
Hi @fredck |
Proposed change
Type of change
Python wheels repository
Additional information
Checklist
icon.png
)[email protected]
)logo.png
)[email protected]
)