Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dreo integration brand #6345

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

w-xtao
Copy link

@w-xtao w-xtao commented Jan 9, 2025

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@w-xtao w-xtao marked this pull request as draft January 9, 2025 03:13
@w-xtao w-xtao marked this pull request as ready for review January 9, 2025 03:15
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jan 13, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @w-xtao 👋

To ensure the logo looks good in Home Assistant, can we remove some of the white/empty space on the top/bottom of the logo versions?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 13, 2025 12:16
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@w-xtao
Copy link
Author

w-xtao commented Jan 14, 2025

Hi there @w-xtao 👋

To ensure the logo looks good in Home Assistant, can we remove some of the white/empty space on the top/bottom of the logo versions?

../Frenck
@frenck
Yes,I 've changed the icon and log picture

@w-xtao w-xtao marked this pull request as ready for review January 14, 2025 08:19
@home-assistant home-assistant bot requested a review from frenck January 14, 2025 08:19
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images added now seem to be app icons, and not branding Dreo is using as their brand identity. Please use the original Dreo branding instead.

I'm not sure why you ended up completely replacing all images with something else 🤷

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 14, 2025 09:48
@w-xtao
Copy link
Author

w-xtao commented Jan 14, 2025

Hi @fredck

Thank you for your feedback! I have removed the blank space at the top and bottom of the logo and optimized its display.
Please let me know if it meets the requirements. If there are any further suggestions, feel free to let me know!

Best regards,
w-xtao

@w-xtao w-xtao marked this pull request as ready for review January 14, 2025 14:06
@home-assistant home-assistant bot requested a review from frenck January 14, 2025 14:06
@frenck
Copy link
Member

frenck commented Jan 14, 2025

I have removed the blank space at the top and bottom of the logo and optimized its display.

Sorry, but that isn't showing. Let me try to explain what I mean:

CleanShot 2025-01-14 at 15 51 26@2x

../Frenck

@frenck frenck marked this pull request as draft January 14, 2025 14:52
Brooke.Wang and others added 2 commits January 15, 2025 09:46
@w-xtao w-xtao marked this pull request as ready for review January 15, 2025 01:50
@w-xtao w-xtao marked this pull request as draft January 15, 2025 02:27
Brooke.Wang and others added 2 commits January 15, 2025 13:59
@w-xtao
Copy link
Author

w-xtao commented Jan 15, 2025

Hi @fredck
Thank you for pointing out my problem. I've removed the white/empty of the logo. To maintain consistency with the logo font, I've changed the icon to black text on a transparent background. If there are still any issues, please feel free to let me know. Thank you.

@w-xtao w-xtao marked this pull request as ready for review January 15, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants