Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Drop pillow as a required dependency #1365

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 28, 2024

I am not completely sure we should drop it, but we should at least postpone the import until it is needed.

datashader/tiles.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.57%. Comparing base (e5182bf) to head (e0c6add).

Files with missing lines Patch % Lines
datashader/tiles.py 25.00% 3 Missing ⚠️
datashader/tests/test_tiles.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1365      +/-   ##
==========================================
- Coverage   88.59%   88.57%   -0.02%     
==========================================
  Files          93       93              
  Lines       18627    18633       +6     
==========================================
+ Hits        16503    16505       +2     
- Misses       2124     2128       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Happy to relax that requirement, as long as we clearly announce the change in the release notes. Thanks!

@hoxbro hoxbro added this to the v0.17.0 milestone Oct 31, 2024
@hoxbro hoxbro changed the title Drop pillow as a required dependency refactor!: Drop pillow as a required dependency Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants