Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'sp+' with '__' around the relation sign in the ref body #473

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndreyTalanin
Copy link

@AndreyTalanin AndreyTalanin commented Nov 4, 2023

Summary

Replaced 'sp+' with '__' (requiring at least 1 whitespace) around the relation sign in the ref body, so it's possible to break a line before or after the relation sign for long Ref declarations representing composite foreign keys.

Issue

#470

Lasting Changes (Technical)

  • Replaced 'sp+' with '__' around the relation sign in the ref body (line 181)
  • Formatted the file on save, trimming trailing whitespaces (actually, unintentionally, can revert it and only leave the first change)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

P.S.

Please, let me know if I should continue with this PR and what else needs to be done (adding tests, etc.).

@NQPhuc
Copy link
Contributor

NQPhuc commented Nov 6, 2023

Hi @AndreyTalanin,

Thank you for your interest in improving dbml.

However, we don't intend to make changes to the current dbml parser, as we're in the process of making a new parser for dbml (#458). Therefore, we'll consider your proposal at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants