added luajit support #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dodo Thanks for the submission; I think I'd better think of a more general way of solving this. |
|
@dodo I've added support in the master branch; please test with that change and let me know if it works! |
| @@ -110,7 +111,7 @@ local function cross_type_order(a, b) | |||
| local pos_b = type_order[ type(b) ] | |||
|
|
|||
| if pos_a == pos_b then | |||
| return a < b | |||
There was a problem hiding this comment.
this isn't working in luajit for me.
$ luajit
> r = require'repl.console'
> r:loadplugin'pretty_print'
> r:run()
> f = {}
> f[pairs] = 23
> f[ipairs] = 42
> return f
/usr/local/share/lua/5.1/repl/plugins/pretty_print.lua:114: attempt to compare two function values
|
See #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the pretty_print plugins was constantly failing for me when trying to print _G in luajit.
I know the bugfix is not pretty, but works for everything.
What do you think?