-
Notifications
You must be signed in to change notification settings - Fork 48
Update Llk.php #91
base: master
Are you sure you want to change the base?
Update Llk.php #91
Conversation
Fix bug hoaproject#90
1 similar comment
@@ -125,7 +125,7 @@ public static function save(Parser $parser, $className) | |||
' \'' . $tokenName . '\' => \'' . | |||
str_replace( | |||
['\'', '\\\\'], | |||
['\\\'', '\\\\\\'], | |||
['\\\'', '\\\\\\\\'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like dumping of these values must be done via var_export(..., true)
. Right now it's unsafe and unpredictable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix the bug within the current mechanism first because it's an easy merge. You can open a PR where var_export is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, using var_export
is not a bad idea at all. And it will simplify the code. Are you willing to try to update with var_export
please?
@@ -125,7 +125,7 @@ public static function save(Parser $parser, $className) | |||
' \'' . $tokenName . '\' => \'' . | |||
str_replace( | |||
['\'', '\\\\'], | |||
['\\\'', '\\\\\\'], | |||
['\\\'', '\\\\\\\\'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, using var_export
is not a bad idea at all. And it will simplify the code. Are you willing to try to update with var_export
please?
@unkind Check this command https://github.com/hoaproject/Devtools#expandflexentities to help you. |
@Hywan I have to find out the real purpose over |
@unkind You can use |
Fix bug #90