DDCNL-9390 Changed OneLogin calls to use new test route #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal22p
previously approved these changes
Oct 22, 2024
grantrobson
previously approved these changes
Oct 23, 2024
Nj147
commented
Nov 1, 2024
| (response.json \ "credentials").as[List[Creds]] | ||
|
|
||
| Right(listOfCreds.map { x => | ||
| x.caUserId |
There was a problem hiding this comment.
I'm sure there's a better way of doing this, but my Friday afternoon brain cannot figure out what it is :(
There was a problem hiding this comment.
Well x => x can be changed to just _ for a start
pascal22p
reviewed
Dec 20, 2024
| _ <- enrolmentStoreServiceTestOnly.insertAccount(account) | ||
| _ <- account.enrolments.map(enrolment => enrolmentStoreServiceTestOnly.upsertEnrolment(enrolment)).sequence | ||
| eacdIds <- identityProviderAccountContextConnectorTestOnly.getEacdIds(account.nino.nino) | ||
| _ <- eacdIds.map(id => oneLoginStubConnectorTestOnly.deleteAccount(id)).sequence |
There was a problem hiding this comment.
delete within insert account details?
Should not it be in the delete account details method?
There was a problem hiding this comment.
Yep should have been, moved it but there's issues with it because the postIndividual doesn't have a working test only which we need to get the eacdIds with the nino so I've asked OL team about getting that added or an alternative way to delete them. So will probably be a 2025 job
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.