ADR-1115 increase connector test coverage with wiremock #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ajchilts
previously approved these changes
Jan 8, 2025
| @@ -105,6 +105,32 @@ class AlcoholDutyReturnsConnectorISpec extends ISpecBase with WireMockHelper{ | |||
| } | |||
| } | |||
|
|
|||
| "should fail when a return is submitted, but something other than a CREATED (202) Status code is returned" in new SetUp { | |||
There was a problem hiding this comment.
Suggest rename test to...
"should fail when an unexpected status code is returned" OR;
"submission should fail when an unexpected status code is returned"
ajchilts
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few pieces of branching logic that weren't being tested in connectors. Just a small PR to increase coverage in these areas. On Scoverage test report with ITs only, the connector coverage is slightly below 100%, but this is just because the loggers are not being printed in ITs. Ticket: https://jira.tools.tax.service.gov.uk/browse/ADR-1115