-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breachparse -- Now in Python #3
base: master
Are you sure you want to change the base?
Conversation
Hi, I the python code works really faster, but it has a problem with multi domain search, it doesn't work. I attached the correct code that should be fix this problem.
|
@alessandromatera You're right, I forgot to add the function for searching multiple domains at once. I pushed a change to fix that. Let me know if you find any more issues. |
@Invoke-Mimikatz Great. I actually found something here:
maybe because there is no password after the colon? |
@alessandromatera Looks like my breachparse data has a decent chunk of lines that separate emails and passwords with characters other than colons. Semicolons and pipes seem to be the second and third most popular delimiter. I just try-catch this in these cases. The whole line still goes into the master file, but not username and password files. |
@Invoke-Mimikatz Hello, me again. I found another issue. It seems that the passwd file is not being filled.
instead of
|
Fixed passwords not being put into the passwords file. Should also correctly handle edge case of passwords containing a colon (eg: Password:123). |
Can you please add a read-me file for the Python version. Thanks. |
Rewrote the bash script in Python3. Bash is one of the slowest languages for large scale data processing. In my measurements the Python script runs 2 to 3 times faster than the Bash script.
Feel free to make edits if you want.