Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#100): fix icon not work in loginConfig props #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# 更新日志

## 3.7.1

- 修复 loginConfig props 中 icon 配置失效,icon 不展示 [#100](https://github.com/XiaoMi/hiui/issues/100)

## 3.7.0

- 添加 disabledAutoFallback props,支持禁用自动 fallback 到第一个有效路由 [#88](https://github.com/XiaoMi/hiui/issues/88)
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hi-ui/classic-theme",
"version": "3.7.0",
"version": "3.7.1",
"description": "Classic theme for HIUI",
"main": "./es/index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Header/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const Header = ({
setLoginVisible(!loginVisible)
}}
>
{typeof menu.icon === 'string' ? <Icon name={menu.icon} style={{ marginRight: 4 }} /> : menu.icon}
{typeof login.icon === 'string' ? <Icon name={login.icon} style={{ marginRight: 4 }} /> : login.icon}
{login.name}
<Icon name={'caret-down'} />
</div>
Expand Down