Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rs-csv-importer.php #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Rebenton
Copy link

@Rebenton Rebenton commented May 3, 2016

With the proposed changes here to RS_CSV_Importer::dispatch() merged into master, you could then use the technique seen in this Gist to extend header(), footer(), greet(), and import() in the same way.

With the proposed changes here to RS_CSV_Importer::dispatch() merged into master, you could then use the technique seen in [this Gist](https://gist.github.com/hissy/199ad9be855ec9be1e54) to extend header(), footer(), greet(), and import() in the same way.
@hissy
Copy link
Owner

hissy commented May 3, 2016

I think this is too much extensibility for my plugin. Could you show me an example to use this?

@Rebenton
Copy link
Author

Rebenton commented May 3, 2016

It'll be a couple days before I have it coded, but I need to modify the import() function to iterate through a directory of CSV files, and pass each one off to process_posts(). The greet, header, and footer additions were simply an effort to make the change applicable to a wider audience.

I can update the pull request in about a week or so when I have the "loop through a directory of CSV files" extension coded.

@hissy
Copy link
Owner

hissy commented May 5, 2016

Actually, I think I did mistake to add this function (replace importer class), because it is too complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants