gh action CI #132
gh action CI #132
Conversation
|
@deantchi If this is still a WIP and not ready for review, can you change this to a draft? |
Dockerfile
Outdated
| @@ -0,0 +1,17 @@ | |||
| FROM rust:bullseye as build | |||
There was a problem hiding this comment.
We already have a similar Dockerfile in dockerfiles/
There was a problem hiding this comment.
we should follow the same pattern as other repos and. that is to keep the Dockerfile at the root of the project.
There was a problem hiding this comment.
I like the idea of keeping the project root nice an clean, we will also probably end up with multiple dockerfiles (debian, alpine, etc).
The dockerfiles directory convention is also adopted in our other repos (https://github.com/hirosystems/clarinet, https://github.com/hirosystems/chainhook).
|
ready for review |
done! |
|
Thanks @deantchi! Looking more closely at the build process, would it be possible to run in parallel:
and only publish the image to docker hub if the test passed? |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
this is just a skeleton CI that build and publishes Hord to docker cloud.
we can treat the PR as a WIP until the CI tasks is complete with testing and any additional CI tasks that may be needed before a release.