Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generic webhook #2333

Merged
merged 15 commits into from
Oct 19, 2023
Merged

add generic webhook #2333

merged 15 commits into from
Oct 19, 2023

Conversation

LeoQuote
Copy link
Collaborator

@LeoQuote LeoQuote commented Oct 13, 2023

  1. 重构 notify 部分的代码, 和engine 的类似, 也是提供一个 base Notifier, 属性有 workflow, audit, 都是原生的 django model, 开发者可以很方便地开发支持的通知方式
  2. 增加 generic webhook 支持, 方便高度的定制需求.

fix #1480

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (815cbd5) 75.50% compared to head (88cea36) 75.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
+ Coverage   75.50%   75.75%   +0.24%     
==========================================
  Files         107      108       +1     
  Lines       15460    15681     +221     
==========================================
+ Hits        11673    11879     +206     
- Misses       3787     3802      +15     
Files Coverage Δ
archery/settings.py 58.92% <100.00%> (+0.37%) ⬆️
common/config.py 83.54% <100.00%> (+3.54%) ⬆️
common/tests.py 100.00% <ø> (ø)
sql/archiver.py 57.03% <100.00%> (+0.50%) ⬆️
sql/test_notify.py 100.00% <100.00%> (ø)
sql/tests.py 98.77% <100.00%> (-0.14%) ⬇️
sql/utils/execute_sql.py 81.35% <100.00%> (ø)
sql/utils/tests.py 100.00% <100.00%> (ø)
sql/utils/workflow_audit.py 97.01% <100.00%> (+0.02%) ⬆️
sql_api/serializers.py 79.88% <100.00%> (+0.11%) ⬆️
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote LeoQuote force-pushed the feat-add-generic-webhook branch from 087fbda to e166023 Compare October 19, 2023 10:45
@LeoQuote LeoQuote marked this pull request as ready for review October 19, 2023 10:52
@LeoQuote LeoQuote merged commit c8fac7e into hhyo:master Oct 19, 2023
10 checks passed
@LeoQuote LeoQuote deleted the feat-add-generic-webhook branch October 19, 2023 16:32
finovy pushed a commit to finovy/Archery that referenced this pull request Nov 10, 2023
* add generic webhook draft

* move notify test out

* change signature, add tests

* delete auto notify usage

* setup can cover the slow query table creation

* 增加测试覆盖率

* fix notify_for_audit usage

* more info in generic webhook

* fix api response

* support setting notifier with env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant