Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Use docker cli instead of Docker Hub v1 API #318

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Atry
Copy link
Contributor

@Atry Atry commented Sep 9, 2022

Docker Hub v1 API has been removed. See https://www.docker.com/blog/docker-hub-v1-api-deprecation/

Test Plan:

$ python3 test.py Test.test_should_run
.
----------------------------------------------------------------------
Ran 1 test in 10.634s

OK

Docker Hub v1 API has been removed. See https://www.docker.com/blog/docker-hub-v1-api-deprecation/

Test Plan:

```
$ python3 test.py Test.test_should_run
.
----------------------------------------------------------------------
Ran 1 test in 10.634s

OK
```
@Atry Atry marked this pull request as draft September 9, 2022 23:50
@Atry
Copy link
Contributor Author

Atry commented Sep 9, 2022

This PR does not work because the Lambda runtime on AWS does not include docker cli

@facebook-github-bot
Copy link
Contributor

Hi @Atry!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants