Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Commit

Permalink
require HHVM 4.99
Browse files Browse the repository at this point in the history
Summary:
Before HHVM 4.99 (this week's release), we get a Hack error:

```
  Typing[4341] The method getCode is not compatible with the overridden method [1]
  -> This function is pure. [2]
  -> This function is normal. [1]

  vendor/hhvm/hsl-experimental/src/os/ErrnoException.php:73:25
       71 |    */
       72 |   <<__Deprecated("Use `getErrno()` instead", 0)>>
  [1]  73 |   final public function getCode()[]: Errno {
       74 |     return $this->errno;
       75 |   }

  /tmp/hh_server/hhi_3a3192f8/exceptions.hhi:103:19
      101 |   public final function setPrevious(Exception $previous)[]: void;
      102 |   <<__Pure, __MaybeMutable>>
  [2] 103 |   public function getCode()[]: int;
      104 |   <<__Pure, __MaybeMutable>>
      105 |   final public function getFile()[]: string;
```

Reviewed By: DavidSnider

Differential Revision: D26853716

fbshipit-source-id: 09a53c62c9fb1a7132e2f18ad15b9782417ac9b6
  • Loading branch information
jjergus authored and facebook-github-bot committed Mar 5, 2021
1 parent 5a13a7d commit 914272c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
matrix:
os: [ ubuntu , macos ]
hhvm:
- '4.93'
- '4.99'
- latest
- nightly
runs-on: ${{matrix.os}}-latest
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"hhvm/hhvm-autoload": "^2.0|^3.0"
},
"require": {
"hhvm": "^4.93",
"hhvm": "^4.99",
"hhvm/hsl": "^4.15"
},
"provide": {
Expand Down

0 comments on commit 914272c

Please sign in to comment.