fix: "Redeclared as the imported package name" error #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcolleen
commented
Aug 25, 2024
| } | ||
|
|
||
| options.Imports = append(options.Imports, `"`+srcPackage.PkgPath+`"`) | ||
| options.Imports = append(options.Imports, srcPackageAlias+` "`+srcPackage.PkgPath+`"`) |
There was a problem hiding this comment.
here the best way is to always use srcPackageAST.Name for package alias. But im afraid we would break backwards compatibility because e.g. minimock has already such import that was added manually https://github.com/gojuno/minimock/blob/master/template.go#L22 . So if we add here import with srcPackageAST.Name alias we would break existing templates because we would have the same import duplicated
generator/generator.go
Outdated
| lastSrcPackagePart := getLastImportPart(srcPackageImport) | ||
| lastImpPart := getLastImportPart(imp.Path.Value) | ||
| if lastImpPart == lastSrcPackagePart { | ||
| srcPackageImportAlias = "__" + lastSrcPackagePart |
There was a problem hiding this comment.
here ideally is to recursively check if there is no such import alias in project already, but i think its to much overheaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix on issue #87