Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use internal http server not default mux #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Gaojianli
Copy link

What type of PR is this?

增加选项:可以不使用默认HTTP Handler,避免对外部造成冲突

What this PR does / why we need it (English/Chinese):

Which issue(s) this PR fixes:

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025

CLA assistant check
All committers have signed the CLA.

options.go Outdated Show resolved Hide resolved
@GuangmingLuo
Copy link
Contributor

Use PR title: feat/fix/chore/docs

@Gaojianli Gaojianli changed the title use internal http server not default mux feat: use internal http server not default mux Jan 20, 2025
@GuangmingLuo
Copy link
Contributor

@Gaojianli please sign CLA mentioned on the comments

@Gaojianli
Copy link
Author

@Gaojianli please sign CLA mentioned on the comments

Should employees of bytedance sign this CLA?

@GuangmingLuo
Copy link
Contributor

Details

Yes, every github account need to sign CLA

@GuangmingLuo
Copy link
Contributor

@Gaojianli Please rebase main to fix CI, thanks

@Gaojianli
Copy link
Author

@Gaojianli Please rebase main to fix CI, thanks

done

@GuangmingLuo
Copy link
Contributor

@rogerogers plz take one more look for the code

@rogerogers
Copy link
Collaborator

useDefaultMuxServer 是有特定含义吗还是拼写错了,我理解是 useDefaultServeMux use default ServeMux 的意思。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants