-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundler versions 2.4.22 and 2.5.6 are now available for Ruby Applications #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/bundler-major-minor
branch
from
February 22, 2024 21:26
698e845
to
32e71b7
Compare
…cations The [Ruby Buildpack](https://devcenter.heroku.com/articles/ruby-support#libraries) now installs a version of bundler based on the major and minor version listed in the `Gemfile.lock` under the `BUNDLED WITH` key. Previously, it only used the major version. Now, this logic will be used: - `BUNDLED WITH` 1.x will receive bundler `1.17.3` - `BUNDLED WITH` 2.0.x to 2.3.x will receive bundler `2.3.25` - `BUNDLED WITH` 2.4.x will receive bundler `2.4.22` - `BUNDLED WITH` 2.5.x and above will receive bundler `2.5.6` It is strongly recommended that you have both a `RUBY VERSION` and `BUNDLED WITH` version listed in your `Gemfile.lock`. If you do not have those values, you can generate them and commit them to git: ``` $ bundle update --ruby $ git add Gemfile.lock $ git commit -m "Update Gemfile.lock" ``` Applications without these values specified in the `Gemfile.lock` may break unexpectedly when the defaults change.
schneems
force-pushed
the
schneems/bundler-major-minor
branch
from
February 22, 2024 21:46
32e71b7
to
4efd7a7
Compare
joshwlewis
reviewed
Feb 27, 2024
joshwlewis
reviewed
Feb 27, 2024
joshwlewis
approved these changes
Feb 27, 2024
Co-authored-by: Josh W Lewis <[email protected]>
Merged
dentarg
added a commit
to dentarg/urls
that referenced
this pull request
Mar 1, 2024
dentarg
added a commit
to Starkast/wikimum
that referenced
this pull request
Mar 3, 2024
Somewhat based on the Dockfile template in Rails: https://github.com/rails/rails/blob/4f0f3448cde85ff3d1485366231650258ea62b71/railties/lib/rails/generators/rails/app/templates/Dockerfile.tt Needed after heroku/heroku-buildpack-ruby#1428 because deploys failed like this: ... Machine started in 390ms Activating bundler (>= 0.a) failed: Permission denied @ rb_sysopen - /workspace/vendor/bundle/ruby/3.2.0/specifications/bundler-2.5.6.gemspec To install the version of bundler this project requires, run `gem install bundler -v '>= 0.a'`
dentarg
added a commit
to Starkast/wikimum
that referenced
this pull request
Mar 3, 2024
Somewhat based on the Dockfile template in Rails: https://github.com/rails/rails/blob/4f0f3448cde85ff3d1485366231650258ea62b71/railties/lib/rails/generators/rails/app/templates/Dockerfile.tt Needed after heroku/heroku-buildpack-ruby#1428 because deploys failed like this: ... Machine started in 390ms Activating bundler (>= 0.a) failed: Permission denied @ rb_sysopen - /workspace/vendor/bundle/ruby/3.2.0/specifications/bundler-2.5.6.gemspec To install the version of bundler this project requires, run `gem install bundler -v '>= 0.a'`
dentarg
added a commit
to Starkast/wikimum
that referenced
this pull request
Mar 3, 2024
Somewhat based on the Dockfile template in Rails: https://github.com/rails/rails/blob/4f0f3448cde85ff3d1485366231650258ea62b71/railties/lib/rails/generators/rails/app/templates/Dockerfile.tt Needed after heroku/heroku-buildpack-ruby#1428 because deploys failed like this: ... Machine started in 390ms Activating bundler (>= 0.a) failed: Permission denied @ rb_sysopen - /workspace/vendor/bundle/ruby/3.2.0/specifications/bundler-2.5.6.gemspec To install the version of bundler this project requires, run `gem install bundler -v '>= 0.a'`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior #1427
Closing #1408
The Ruby Buildpack now installs a version of bundler based on the major and minor version listed in the
Gemfile.lock
under theBUNDLED WITH
key. Previously, it only used the major version. Now, this logic will be used:BUNDLED WITH
1.x will receive bundler1.17.3
BUNDLED WITH
2.0.x to 2.3.x will receive bundler2.3.25
BUNDLED WITH
2.4.x will receive bundler2.4.22
BUNDLED WITH
2.5.x and above will receive bundler2.5.6
It is strongly recommended that you have both a
RUBY VERSION
andBUNDLED WITH
version listed in yourGemfile.lock
. If you do not have those values, you can generate them and commit them to git:Applications without these values specified in the
Gemfile.lock
may break unexpectedly when the defaults change.