Disable io_uring use in libuv
#1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
approved these changes
Nov 20, 2024
Merged
htiwari1987
pushed a commit
to SalesforceDocs-Bot/sfdocs-heroku-buildpack-nodejs
that referenced
this pull request
Nov 21, 2024
* Disable `io_uring` use in `libuv` amazonlinux/amazon-linux-2023#840 (comment) * Update CHANGELOG.md
SalesforceDocs-Bot
pushed a commit
to SalesforceDocs-Bot/sfdocs-heroku-buildpack-nodejs
that referenced
this pull request
Nov 21, 2024
* Disable `io_uring` use in `libuv` amazonlinux/amazon-linux-2023#840 (comment) * Update CHANGELOG.md Co-authored-by: Colin Casey <[email protected]>
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Nov 21, 2024
Default `UV_USE_IO_URING=0` due to build timeouts This mirrors a change by the nodejs buildpack: heroku/heroku-buildpack-nodejs#1347 The Ruby buildpack needs this because we can install node/yarn without the `heroku/nodejs` buildpack, however this behavior triggers a warning and is generally advised against.
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Nov 21, 2024
Default `UV_USE_IO_URING=0` due to build timeouts This mirrors a change by the nodejs buildpack: heroku/heroku-buildpack-nodejs#1347 The Ruby buildpack needs this because we can install node/yarn without the `heroku/nodejs` buildpack, however this behavior triggers a warning and is generally advised against.
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Nov 21, 2024
…ault (#1523) * Set UV_USE_IO_URING=0 by default Default `UV_USE_IO_URING=0` due to build timeouts This mirrors a change by the nodejs buildpack: heroku/heroku-buildpack-nodejs#1347 The Ruby buildpack needs this because we can install node/yarn without the `heroku/nodejs` buildpack, however this behavior triggers a warning and is generally advised against. * Only set UV_USE_IO_URING=0 at build (not runtime) * Make UV_USE_IO_URING=0 available for other buildpacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suspect that this bug in Amazon Linux 2023 is causing build timeouts on the platform:
amazonlinux/amazon-linux-2023#840 (comment)
We were able to reproduce these build timeouts and, following the guidance to set
UV_USE_IO_URING=0allowed our builds that were timing out to succeed.