Skip to content
This repository has been archived by the owner on Nov 13, 2020. It is now read-only.

add environment vars to pre/post compile hook #23

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

add environment vars to pre/post compile hook #23

wants to merge 10 commits into from

Conversation

nraynaud
Copy link

@nraynaud nraynaud commented Apr 1, 2016

Those are visible in the default python buildpack, but are noticeably absent from the conda buildpack.
They are useful for migrating the database.

@codingjoe
Copy link

Hi, i just saw your PR. I don't thing you should export anything here. If you'd want to access the vars in the hooks, the hooks need to be sourced. Currently they are just executed. You could do this step in your hooks than, since you'd have access to $ENV_DIR

@massover
Copy link

@codingjoe can you elaborate on 'the hooks need to be sourced'? I don't understand your suggestion

@codingjoe
Copy link

If they are not sourced, you don't have access to variables defined in the compile script unless they have been exported, which they don't.
You can also use the sub-env command that was introduced in the official python buildpack.
Besides, I did all that here: https://github.com/Thermondo/conda-buildpack

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants