New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print empty block semicolon with comments #152

Merged

helixbass merged 2 commits into master from iss136-empty-block-semicolon-comments

Dec 31, 2019

Owner

helixbass commented Dec 31, 2019 •

edited

Loading

In this PR:

fix the parse-error-causing bug from Formatting: semicolon inline comment gets pushed to previous line #136 where empty if blocks with comments weren't printing the ;

Not in this PR:

didn't get positioning of comments relative to the ; stabilized - this would seem to involve overriding how printDanglingComments() works because it seems to assume that it should print them on their own lines (rather than eg needing to keep # eslint-disable-line comments trailing on the same line)

helixbass added 2 commits

December 31, 2019 13:54


          print semicolon for if with comment

1f4c147


          tests

ee07cd2

helixbass merged commit ab59b56 into master

helixbass deleted the iss136-empty-block-semicolon-comments branch

December 31, 2019 22:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet