Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Do not disable libsecp's constant time tests #253

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jul 2, 2024

This PR addresses #192 (comment):

Ok, but the ctime tests are currently compiled, and runnable there.

and mirrors the behavior of the master branch.

Assuming the Valgrind is installed, after building the user can tun:

$ valgrind ./build/src/secp256k1/src/ctime_tests

This change mirrors the behavior of the master branch.
@hebasto hebasto added the bug Something isn't working label Jul 2, 2024
@hebasto hebasto added this to the Ready for master milestone Jul 2, 2024
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d2ab006

@hebasto hebasto merged commit fec5dcd into cmake-staging Jul 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants