Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix clang-tidy CI task #249

Merged
merged 1 commit into from
Jul 1, 2024
Merged

cmake: Fix clang-tidy CI task #249

merged 1 commit into from
Jul 1, 2024

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Jun 30, 2024

#192 introduced a regression in the "clang-tidy" CI task. For instance, see https://cirrus-ci.com/task/6601636905222144 from bitcoin#29790.

The reason is that disabling EXPORT_COMPILE_COMMANDS for secp256k1 target only is not enough because the subtree's build system has other intermediate build targets internally.

@hebasto hebasto added the bug Something isn't working label Jun 30, 2024
@hebasto hebasto added this to the Ready for master milestone Jun 30, 2024
Copy link

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dc32026

@hebasto hebasto merged commit 6afc48f into cmake-staging Jul 1, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants