Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Doctrine ORM 3 support #44

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Conversation

wazum
Copy link
Contributor

@wazum wazum commented Jan 3, 2025

Add Doctrine ORM 3 support and add integration tests for multiple platforms.

wazum added 2 commits January 3, 2025 09:03
Add integration tests with SQLite, MySQL, PostgreSQL.
Run SQLite tests on Windows and Linux.
Run MySQL/PostgreSQL tests on Linux.
@wazum wazum force-pushed the feature/doctrine-orm-3 branch from e359ce5 to 3e37272 Compare January 3, 2025 08:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if it's possible to extract the "matrix" block so that it can be shared between jobs? It seems like unnecessary duplication, and is something we'll be updating with every PHP release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I checked the documentation and the GitHub issues and this is not currently supported. There are ways to make this work through some obscure tricks, but that makes the whole thing harder to read.
Supposedly this feature will be coming to GitHub later this year, but who knows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we can manage this manually for now then. Will merge and release a new version shortly.

@benr77
Copy link
Contributor

benr77 commented Jan 3, 2025

All this looks really good thank you. Happy to merge but just have the one query about the matrix block duplication in the CI config. That is not a blocker though.

@benr77 benr77 merged commit 40ad17d into headsnet:main Jan 4, 2025
70 checks passed
@wazum wazum deleted the feature/doctrine-orm-3 branch January 6, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants