-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Strapi-to-OPAC pipeline for title data (RPB-202) #95
Draft
fsteeg
wants to merge
7
commits into
main
Choose a base branch
from
rpb-202-strapiToOpac
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsteeg
added a commit
that referenced
this pull request
Oct 18, 2024
Reviewed in https://jira.hbz-nrw.de/browse/RPB-202, will deploy and merge. |
fsteeg
changed the title
Set up basic Strapi-to-OPAC pipeline for title data (RPB-202)
Switch to Strapi-to-OPAC pipeline for title data (RPB-202)
Nov 8, 2024
Since this actually switches the pipeline to Strapi data, we will only merge and deploy this after the final Allegro export. Converting to draft until then. |
Article is a separate content type in Strapi, has no own type field
Based on Allegro data; GND entries in rpb-authorities have been removed from Strapi data in https://jira.hbz-nrw.de/browse/RPB-172 `cat conf/RPB-Export_HBZ_SW.tsv | grep -E -w '^[0-9]+n?[0-9X]?'` Possible approaches to include new GND entries used in RPB records might be using the Strapi labels (add `afterFindMany` hook and make the labels non-private, see [1] for an implementation; all those label lookups might significantly impact performance though), or showing the labels dynamically in the web OPAC only. [1] https://github.com/hbz/strapi-rpb/pull/45/files
fsteeg
force-pushed
the
rpb-202-strapiToOpac
branch
from
November 8, 2024 13:31
d53ee13
to
fe84bd9
Compare
Next step is switching cataloging for articles only (RPB-202).
fsteeg
force-pushed
the
rpb-202-strapiToOpac
branch
from
November 8, 2024 13:39
fe84bd9
to
dd17b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.hbz-nrw.de/browse/RPB-202