Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode URL properly #531

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Encode URL properly #531

merged 2 commits into from
Oct 15, 2024

Commits on Oct 11, 2024

  1. Encode URL properly (lobid-gnd#408) 

    Question marks weren't encoded. It's better to use a library.
    @dr0i
    dr0i committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    98459aa View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Preserve the query parameter (lobid-gnd#408) 

    The PHP parse-url function cannot be used to separate "URL path" and "URL
query" because if an "?" is part of the path it would be nontheless
identified as a query parameter. Explicitly stick to the last "?" seems
to be safe in the context of wikimedia commmons at least.
    @dr0i
    dr0i committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6f891a3 View commit details
    Browse the repository at this point in the history