2095-noOverwritingHbzId #2096
Merged
2095-noOverwritingHbzId #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build fails. |
dr0i
approved these changes
Nov 14, 2024
|
I unassigne Adrian as reviewer, since he should only see that we introduced this change. Due to the discussion at metadaten.community. |
|
@dr0i can you merge and deploy since the automatic deployment is already through? |
|
Manually deployed. Data should be updated next Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a conditional to stop overwriting existing
hbzId.Context:
There are old aleph zdb records that have zdb id informations
in their MAB data in
026-1but not in025z1.Due to this in context of the migration to ALMA their HT number was not replaced by the ZDB ID. Also in the old aleph lobid mapping these records had no
zdbIde.g. see:
ALEPH: http://lobid.org/hbz01/HT019286510 // https://aleph.lobid.org/resources/HT019286510
ALMA: https://lobid.org/marcxml/990217879290206441 // https://lobid.org/resources/990217879290206441
To ensure that old links still work we added an enrichment of all records with zdbId that are part of the NZ based on the latest data from aleph data before the switch to ALMA as master.
Also we with ALMA we started to catch the ZDB ID from
035not only when they have the prefix(DE-600)but also if(DE-599)ZDB.This resulted in overwriting existing hbzId in the records with mapped ones. We want to adjust this mechanism so that only records WITHOUT
zdbIdare enriched with their oldhbzId