lookup formangabe #2090
lookup formangabe #2090
Conversation
There was a problem hiding this comment.
Fixes look good. But I would change the commits a bit so that you can better see the changes that your code introduces.
Add the test records from 1fed759 in an commit before adding the changes in the code.
In a second commit add the changes in the fixes as well as the changes that result when running: ~/git/lobid-resources$ mvn clean install -DskipTests=false -DgenerateTestData=true. You can also fix the formatting in this commit.
In a third commit add http://lobid.org/resources/99374153235806441 as test for fixing the columns of the formangaben lookup.
In a fourth commit add your changes to the fix from: bb77c45 as well as the changes that result when running: ~/git/lobid-resources$ mvn clean install -DskipTests=false -DgenerateTestData=true.
In a last commit update the web app tests or you could add the updates of the web app tests when introducing a new test. (Which I usually forget)
|
@TobiasNx Thx for your suggestions. As the JSON was not created due to the incorrect transformation, it is not possible to see the changes between two results. I have therefore edited this in one step. Where does the example http://lobid.org/resources/99374153235806441 come from? Sorry, but I cannot see any relation to #2082. |
The example came up in context of #2028 and was provided by you having a wrong publication date. But the JSON Schema Tests og the github action failed due to the mapped natureOfContent.id being wrong: https://github.com/hbz/lobid-resources/actions/runs/11680572050/job/32523855291#step:8:187 It will be fixed by your commit: bb77c45 Therefore it would be a good test file for this commit. |
|
replaced by #2092 |
Related to #2082