Reuse nwbib fix for #1992, #1951 and #1829

[TobiasNx]

Resolves #1951 and #1829 Wrong ISBN and ISSN

and also fixes #1992 missing linking to Bände and Enthält

hbz/nwbib#636

[fsteeg]

Build in GitHub Action fails, the change does not compile. You should always test locally (sbt run in web/) before pushing, and check the GitHub Action before opening a PR.

[TobiasNx]

@fsteeg you are right. It does not compile and the solution is not as easy as just copying the lines from the nwbib project. I assume that the failed compiling is due to nwbib still using JAVA 8 and lobid JAVA 11

[fsteeg]

I assume that the failed compiling is due to nwbib still using JAVA 8 [...]

You can see the error in the build log of the GitHub Action:

https://github.com/hbz/lobid-resources/actions/runs/10678801716/job/29596615852?pr=2067#step:10:900

The problem seems to be the actual code change.

the solution is not as easy as just copying the lines from the nwbib project

Yes, but if you have it running locally I'm sure we can set it up together.

[TobiasNx]

@fsteeg now it should work.

[fsteeg]

I've deployed your change to test: https://test.lobid.org/resources

now it should work.

Bände / Enthält seems to work now, but the ISBN / ISSN fields now show the full URI ID. In general, I think it would be better to have separate PRs for these separate issues (we've had that topic in the last Metafacture meeting too). Also, it would really be more efficient if you get your setup running locally, so you can test if it actually works before pushing and requesting a review.

[TobiasNx]

Had a look at Table row values that is called for ISBN and ISSN, NwBib seems to differ a lot from lobid. I am not sure how to solve this any further.

[fsteeg]

I've replaced the jsonVal block with the nwbib version: fcf01f4

Seems good now, e.g.: https://test.lobid.org/resources/990366384450206441